Impossible to select any notes on C-1

[Softy107]

Describe the bug
It is impossible to select any notes on C-1 for some reason

To Reproduce
Steps to reproduce the behavior:

1. Go to signal.vercel.app
2. Add some notes into C-1
3. Lower the Velocity panel
4. Try to select the notes, then See error

Expected behavior
The notes should select normally and would be able to copy, paste, etc.

Screenshots

(mouse not visible, but it is under the selected area I promise)

Desktop (please complete the following information):

• OS: Windows 10 education
• Browser : MS Edge
• Version : Version 103.0.1264.71 (Official build) (64-bit) (browser ver)

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
it is also impossible to put selected notes into C-1 without using arrow keys -

(same here, still not visible but it is under the selected area)

[robertnhart]

It looks like Signal's code uses a half-open interval to describe the range of selected notes:

• the from note number is the note number at the top of the selection.
• the to note number is the note number just underneath the bottom of the selection.

In order for the selection to include the minimum pitch 0 (C-1), the to note number needs to be -1. However, various parts of the code are clamping values to a minimum of zero.

In particular, in the file src/main/actions/selection.ts, in the function resizeSelection:

• the regularizedSelection function call at the beginning does some clamping
• the clampSelection function call at the end also does some clamping

Here is the potential fix I came up with:

• In the defintion of regularizedSelection, remove the parts that clamp note numbers to a minumum of zero:

-    Math.max(0, Math.max(fromNoteNumber, toNoteNumber)),
+                Math.max(fromNoteNumber, toNoteNumber) ,

-    Math.max(0, Math.min(fromNoteNumber, toNoteNumber)),
+                Math.min(fromNoteNumber, toNoteNumber) ,

• At the end of resizeSelection, increment the to note number before clamping it, then decrement it after clamping it:

-    const selection
+    let   selection

-    pianoRollStore.selection = clampSelection(selection)

+    ++selection.to.noteNumber;
+    selection = clampSelection(selection);
+    --selection.to.noteNumber;
+    pianoRollStore.selection = selection;

I will submit a pull request.