fix: apply hide_console_windows to spawnSync calls

kHideConsoleWindows should hide console windows for execSync and spawnSync calls as well. This fix adds on to nodejs#39712.
rzhao271 · Jan 5, 2022 · f77a197 · f77a197
1 parent 55ceaec
commit f77a197
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc
@@ -810,6 +810,9 @@ Maybe<int> SyncProcessRunner::ParseOptions(Local<Value> js_value) {
   if (js_win_hide->BooleanValue(isolate))
     uv_process_options_.flags |= UV_PROCESS_WINDOWS_HIDE;
 
+  if (env()->hide_console_windows())
+    uv_process_options_.flags |= UV_PROCESS_WINDOWS_HIDE_CONSOLE;
+
   Local<Value> js_wva =
       js_options->Get(context, env()->windows_verbatim_arguments_string())
           .ToLocalChecked();