Add support for windows environments using mingw and/or cygwin. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tovrleaf
requested changes
Nov 16, 2021
ad-aws-login.sh
Outdated
|
|
||
| while read -r path; do | ||
| while read -r browser; do | ||
| if [[ -f "${path}/${browser}" ]]; then |
There was a problem hiding this comment.
This does not work in OSX. ${path}/${browser} is a directory, not a file
There was a problem hiding this comment.
Added original method back in addition to the file based testing.
There was a problem hiding this comment.
I think this would be a bit cleaner by using OR in one statement, instead of having two duplicate if-statements in a row
tovrleaf
reviewed
Nov 17, 2021
| function open_browser() { | ||
| local os=$(read_os) | ||
|
|
||
| read browser browser_path < <(find_browser) |
There was a problem hiding this comment.
This is what happens:
browser="Google"
browser_path="Chrome /Applications"
should be instead:
browser="Google Chrome"
browser_path="/Applications"
This will not work since read command assumes spaces for token separators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a review and testing with Mac