Skip to content

Commit

Permalink
馃┕Fix broken deployment build (#246)
Browse files Browse the repository at this point in the history
* 馃┕ Downgraded size-plugin to 2.0.2 

since version 3.0.0 doesn't work with webpack 5.

Ref: GoogleChromeLabs/size-plugin#40 (comment)

* 馃┕ Fixed 'npm run update_manifest_firefox' and added test to 'Test' workflow


Fixes the Error:
$ npm run update_manifest_firefox

> @ update_manifest_firefox /home/runner/work/binge-stream/binge-stream
> npx ts-node tools/firefox_manifest_append.ts

npx: installed 14 in 2.154s
(node:1884) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
Cannot use import statement outside a module
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ update_manifest_firefox: `npx ts-node tools/firefox_manifest_append.ts`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @ update_manifest_firefox script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

* 馃┕ Fixed typo and added 'package-lock.json' to misspell ignore
  • Loading branch information
s-weigand committed Sep 10, 2021
1 parent 63b093f commit b22e593
Show file tree
Hide file tree
Showing 4 changed files with 28,462 additions and 14,485 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,20 @@ jobs:
- name: misspell
uses: reviewdog/action-misspell@v1
with:
reporter: github-pr-review
reporter: github-pr-check
github_token: ${{ secrets.github_token }}
level: warning
locale: 'US'
exclude: |
./package-lock.json
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: npm ci
- run: npm run test:prod
- name: "Test build step: update Manifest for FireFox"
run: npm run update_manifest_firefox
- name: Upload dist bundle
uses: actions/upload-artifact@v1
with:
Expand Down

0 comments on commit b22e593

Please sign in to comment.