remove warning on success #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadmk11
requested changes
Mar 16, 2023
| @@ -152,9 +152,6 @@ def _update_workflow(self, workflow_path: str) -> set[str]: | |||
| ) | |||
|
|
|||
| if not new_version: | |||
| gha_utils.warning( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be misunderstanding something, but currently, when I run this action on my repo, and my actions are up to date, I get lots of warnings like this:
If the action is up to date, I don't think a warning should be printed to the action annotations. I think nothing should be printed at all, because the check was successful-- an action was found, and it's up to date.
If I'm wrong and this should be a warning, please update the warning to explain what the problem is.