Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade react native to latest version #259

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: upgrade react native to latest version #259

wants to merge 1 commit into from

Conversation

ledutu2
Copy link
Contributor

@ledutu2 ledutu2 commented Oct 5, 2023 •
edited

loc-nguyenthien
loc-nguyenthien requested changes Feb 23, 2024
View reviewed changes
template/__tests__/App.test.js
@@ -6,6 +6,9 @@ import 'react-native'
import React from 'react'
import App from '../App'

// Note: import explicitly to use the types shiped with jest.
import {it} from '@jest/globals'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only import to use types, can we usse import '@jest/globals'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loc-nguyenthien loc-nguyenthien loc-nguyenthien requested changes

@honghoangsts honghoangsts Awaiting requested review from honghoangsts honghoangsts is a code owner

@baonguyenhsts baonguyenhsts Awaiting requested review from baonguyenhsts baonguyenhsts is a code owner

@anhle10051996 anhle10051996 Awaiting requested review from anhle10051996

@hoangSTS hoangSTS Awaiting requested review from hoangSTS hoangSTS is a code owner

@huydosgtech huydosgtech Awaiting requested review from huydosgtech huydosgtech is a code owner

@loido loido Awaiting requested review from loido loido is a code owner

@ThinhKimVo ThinhKimVo Awaiting requested review from ThinhKimVo ThinhKimVo is a code owner

@vunguyendhSTS vunguyendhSTS Awaiting requested review from vunguyendhSTS

@ngochuyduong ngochuyduong Awaiting requested review from ngochuyduong ngochuyduong is a code owner

@hangnguyensaigontech hangnguyensaigontech Awaiting requested review from hangnguyensaigontech hangnguyensaigontech is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@ledutu2 ledutu2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ledutu2 @loc-nguyenthien