Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded minSdk version #22

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Downgraded minSdk version #22

merged 2 commits into from
Sep 29, 2023

Conversation

KitsuneFolk
Copy link
Contributor

@KitsuneFolk KitsuneFolk commented Sep 27, 2023

  1. Changed the library's and the example's minSdk to 21(from 23 and 31 respectively). I also created Theme.kt which contains LightTheme and DarkTheme for android version <12 because previously there were used dynamic themes that threw an Exception
  2. Updated androidx-compose-ui-material3

compileSdk = "34"
kotlin = "1.9.10"
agp = "8.1.0"
androidx-compose-ui = "1.5.1" # https://developer.android.com/jetpack/androidx/releases/compose-ui
androidx-compose-ui-material3 = "1.1.1"
androidx-compose-ui-material3 = "1.1.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo this change? It's best to keep unrelated changes separate from a PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll make a commit reverting this change tomorrow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is reversed.

sample/build.gradle.kts Show resolved Hide resolved
Copy link
Owner

@saket saket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MrRuslanYT!

@saket saket merged commit b4dd2dc into saket:trunk Sep 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants