Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(env/java): improve tests and implementation (#1246) #6

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

sakibguy
Copy link
Owner

This basically fixes up the changes from apache#1220.

  • test(env/java): replace test that duplicates implementation
  • test(env/java): stub _ensure to focus on unit under test
  • test(env/java): add test for invalid output
  • refactor(env/java): keep try block small
  • refactor(env/java): shorten excessive comment

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

This basically fixes up the changes from #1220.

* test(env/java): replace test that duplicates implementation
* test(env/java): stub _ensure to focus on unit under test
* test(env/java): add test for invalid output
* refactor(env/java): keep try block small
* refactor(env/java): shorten excessive comment
@sakibguy sakibguy added bug Something isn't working documentation Improvements or additions to documentation labels Jun 24, 2021
@sakibguy sakibguy self-assigned this Jun 24, 2021
@sakibguy sakibguy merged commit 64cec9e into sakibguy:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
2 participants