[ORG] USA-UDACITY: Add test to superfluous-parens
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional test based on a suggestion in #4907
* Add type annotations to ``visit`` & ``leave`` calls This adds typing to most calls that visit nodes. All other changes are due to mypy errors resulting from introduction of typing. * Fix outstanding mypy issues This removes some of the `type: ignore` comments in favour of solving the mypy issues these comments were surpressing. * Fix remaining references to node_classes Except for two references to node_classes in the changelog this should be the last of them Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Based on discussion in #4787 Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
sakibguy
commented
Sep 4, 2021
| @@ -36,9 +36,11 @@ Firstly we will need to fill in some required boilerplate: | |||
| .. code-block:: python | |||
|
|
|||
| import astroid | |||
| from astroid import nodes | |||
|
|
||
| from pylint.checkers import BaseChecker | ||
| from pylint.interfaces import IAstroidChecker | ||
| from pylint.lint import PyLinter |
| @@ -117,14 +119,14 @@ Next we'll track when we enter and leave a function. | |||
|
|
|||
| .. code-block:: python | |||
|
|
|||
| def __init__(self, linter=None): | |||
| def __init__(self, linter: PyLinter =None) -> None: | |||
| super(UniqueReturnChecker, self).__init__(linter) | ||
| self._function_stack = [] | ||
|
|
||
| def visit_functiondef(self, node): | ||
| def visit_functiondef(self, node: nodes.FunctionDef) -> None: |
| self._function_stack.append([]) | ||
|
|
||
| def leave_functiondef(self, node): | ||
| def leave_functiondef(self, node: nodes.FunctionDef) -> None: |
| @@ -11,7 +11,7 @@ class Klass(object): | |||
| print(Klass().aBC_set1) | |||
| print(Klass().ham.does.not_.exist) | |||
| print(Klass().spam.does.not_.exist) # [no-member] | |||
| node_classes.Tuple.does.not_.exist | |||
| nodes.Tuple.does.not_.exist | |||
| @@ -6,6 +6,6 @@ generated-members= | |||
| \Afunctional\.g\.generated_members\.Klass\.ham\Z, | |||
| DoesNotExist, | |||
| "[a-zA-Z]+_set{1,2}", | |||
| node_classes.Tuple.*, | |||
| nodes.Tuple.*, | |||
|
|
||
| def visit_if(self, node): | ||
| from astroid import nodes | ||
| def visit_if(self, node: nodes.If) -> None: |
| @@ -80,7 +80,7 @@ class A: | |||
|
|
|||
|
|
|||
| @patch("pylint.pyreverse.utils.get_annotation") | |||
| @patch("astroid.node_classes.NodeNG.infer", side_effect=astroid.InferenceError) | |||
| @patch("astroid.nodes.NodeNG.infer", side_effect=astroid.InferenceError) | |||
| @@ -93,7 +93,7 @@ def test_infer_node_1(mock_infer, mock_get_annotation): | |||
|
|
|||
|
|
|||
| @patch("pylint.pyreverse.utils.get_annotation") | |||
| @patch("astroid.node_classes.NodeNG.infer") | |||
| @patch("astroid.nodes.NodeNG.infer") | |||
sakibguy
changed the title
superfluous-parenssuperfluous-parens
sakibguy
changed the title
superfluous-parenssuperfluous-parens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional test based on a suggestion in pylint-dev#4907
Type of Changes
Description
Closes #XXX