Fix CMS app issues #386

orzechdev · 2023-04-13T13:07:26Z

Fixes for #314

plus:

error notifications on sync issues
checking connection status of configuration instance, closes Check if CMS provider instance configuration is working #242
skipping update webhooks processing if issuing principal is this same CMS app (app bulk product sync was causing triggering unnecessary product and variant webhook events, due to updating metadata with ID from CMS provider, where product variant data was uploaded/removed from). Related Prevent app to receive webhook for event this app has triggered saleor#12538.

vercel · 2023-04-13T13:07:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
saleor-app-data-importer	🔄 Building (Inspect)	Visit Preview		Apr 18, 2023 4:43pm

10 Ignored Deployments

Name	Status	Preview	Updated (UTC)
saleor-app-cms	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-crm	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-emails-and-messages	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-invoices	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-klaviyo	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-monitoring	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-products-feed	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-search	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-slack	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm
saleor-app-taxes	⬜️ Ignored (Inspect)	Visit Preview	Apr 18, 2023 4:43pm

changeset-bot · 2023-04-13T13:07:30Z

🦋 Changeset detected

Latest commit: ad11269

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
saleor-app-cms	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

lkostrowski · 2023-04-18T10:46:44Z

apps/cms/package.json

@@ -61,7 +61,7 @@
    "eslint-config-prettier": "^8.5.0",
    "jsdom": "^20.0.3",
    "prettier": "^2.7.1",
-    "typescript": "4.9",
+    "typescript": "5.0.4",


is there a reason to update TS in this PR? Its fine, but Vercel has some problems when we update deps in single pkg

Yes there is a reason. Somewhere in this code I have encountered Typescript regression issue that has been submitted at microsoft/TypeScript#51501 and that has been fixed in Typescript 5.0.0 release.

lkostrowski · 2023-04-18T11:32:33Z

@orzechdev pls add changeset describing changes from this PR

vercel bot deployed to Preview – saleor-app-klaviyo April 13, 2023 13:07 View deployment

orzechdev added the App: CMS label Apr 13, 2023

github-actions bot assigned orzechdev Apr 13, 2023

vercel bot deployed to Preview – saleor-app-monitoring April 13, 2023 13:08 View deployment

vercel bot deployed to Preview – saleor-app-taxes April 13, 2023 13:08 View deployment

vercel bot deployed to Preview – saleor-app-search April 13, 2023 13:08 View deployment

vercel bot deployed to Preview – saleor-app-products-feed April 13, 2023 13:10 View deployment

vercel bot deployed to Preview – saleor-app-data-importer April 13, 2023 13:11 View deployment

vercel bot deployed to Preview – saleor-app-cms April 13, 2023 13:12 View deployment

vercel bot deployed to Preview – saleor-app-invoices April 13, 2023 13:14 View deployment

vercel bot deployed to Preview – saleor-app-emails-and-messages April 13, 2023 13:14 View deployment

vercel bot deployed to Preview – saleor-app-slack April 13, 2023 13:14 View deployment

vercel bot deployed to Preview – saleor-app-crm April 13, 2023 13:16 View deployment

vercel bot deployed to Preview – saleor-app-cms April 13, 2023 16:46 View deployment

vercel bot had a problem deploying to Preview – saleor-app-cms April 14, 2023 09:10 Failure

orzechdev changed the title ~~Fix CMS app visual issues~~ Fix CMS app issues Apr 14, 2023

orzechdev force-pushed the cms-qa-fixes branch from 685a99e to 7691ee3 Compare April 14, 2023 09:34

vercel bot deployed to Preview – saleor-app-taxes April 14, 2023 09:55 View deployment

vercel bot deployed to Preview – saleor-app-cms April 14, 2023 10:07 View deployment

orzechdev marked this pull request as ready for review April 16, 2023 16:26

orzechdev requested a review from a team April 16, 2023 16:26

orzechdev marked this pull request as draft April 16, 2023 22:10

vercel bot deployed to Preview – saleor-app-cms April 17, 2023 12:59 View deployment

orzechdev force-pushed the cms-qa-fixes branch from dd3635c to 8b32979 Compare April 17, 2023 13:01

vercel bot deployed to Preview – saleor-app-cms April 17, 2023 13:03 View deployment

orzechdev marked this pull request as ready for review April 18, 2023 07:26

orzechdev added 2 commits April 18, 2023 09:28

Fix CMS app visual issues

90edc18

Add provider configuration instance ping status

d51e701

orzechdev added 2 commits April 18, 2023 09:32

Skip update webhooks processing if issuing principal is this CMS app

891a281

Fix provider configuration form validation

f5bf51d

orzechdev force-pushed the cms-qa-fixes branch from 8b32979 to f5bf51d Compare April 18, 2023 07:32

vercel bot deployed to Preview – saleor-app-invoices April 18, 2023 07:33 View deployment

vercel bot deployed to Preview – saleor-app-slack April 18, 2023 07:34 View deployment

vercel bot deployed to Preview – saleor-app-search April 18, 2023 07:36 View deployment

vercel bot deployed to Preview – saleor-app-data-importer April 18, 2023 07:37 View deployment

vercel bot deployed to Preview – saleor-app-monitoring April 18, 2023 07:39 View deployment

vercel bot deployed to Preview – saleor-app-cms April 18, 2023 07:39 View deployment

vercel bot deployed to Preview – saleor-app-taxes April 18, 2023 07:42 View deployment

vercel bot deployed to Preview – saleor-app-emails-and-messages April 18, 2023 07:42 View deployment

vercel bot deployed to Preview – saleor-app-klaviyo April 18, 2023 07:43 View deployment

vercel bot deployed to Preview – saleor-app-crm April 18, 2023 07:44 View deployment

vercel bot deployed to Preview – saleor-app-products-feed April 18, 2023 07:45 View deployment

lkostrowski approved these changes Apr 18, 2023

View reviewed changes

Create old-dingos-hide.md

ad11269

orzechdev merged commit a3636f7 into main Apr 18, 2023
15 checks passed

orzechdev deleted the cms-qa-fixes branch April 18, 2023 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CMS app issues #386

Fix CMS app issues #386

orzechdev commented Apr 13, 2023 •

edited

vercel bot commented Apr 13, 2023 •

edited

changeset-bot bot commented Apr 13, 2023 •

edited

lkostrowski Apr 18, 2023

orzechdev Apr 18, 2023 •

edited

lkostrowski commented Apr 18, 2023

Fix CMS app issues #386

Fix CMS app issues #386

Conversation

orzechdev commented Apr 13, 2023 • edited

vercel bot commented Apr 13, 2023 • edited

changeset-bot bot commented Apr 13, 2023 • edited

🦋 Changeset detected

lkostrowski Apr 18, 2023

Choose a reason for hiding this comment

orzechdev Apr 18, 2023 • edited

Choose a reason for hiding this comment

lkostrowski commented Apr 18, 2023

orzechdev commented Apr 13, 2023 •

edited

vercel bot commented Apr 13, 2023 •

edited

changeset-bot bot commented Apr 13, 2023 •

edited

orzechdev Apr 18, 2023 •

edited