Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show charge and authorised amount in payment section of order details #4821

Merged
merged 16 commits into from
May 16, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Apr 24, 2024

AC:

  • User should see Authorized, Captured and Cancelled amounts in the Payment summary section when order with a transaction
  • User should see pending payments amount only when have amount greater than 0
  • User should see "Mark as paid" when the order does not have a charge and authorized amount, can not be refunded and it does not have a gift card, otherwise, we show Authorized, Captured and Cancelled amount

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Screenshot 2024-04-26 at 14 06 54

@poulch poulch requested a review from a team as a code owner April 24, 2024 10:00
Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 091c2bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4821 April 24, 2024 10:03 Destroyed
Droniu
Droniu previously approved these changes Apr 24, 2024
@github-actions github-actions bot temporarily deployed to pr-4821 April 24, 2024 11:35 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4821 April 25, 2024 07:47 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4821 April 25, 2024 10:09 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4821 April 26, 2024 06:55 Destroyed
Droniu
Droniu previously approved these changes Apr 26, 2024
@github-actions github-actions bot temporarily deployed to pr-4821 April 26, 2024 11:17 Destroyed
Copy link
Member

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the payment section now will show all payments info, aggregated from all transactions in a given order, we should inform the user about that:

  • We can call the section "Payments summary" instead of "Payment"
  • We can add small text right below the title that explains what it presents eg. "A summary of all payments from registered transactions"

What do you think?

@poulch poulch requested a review from Droniu April 26, 2024 12:19
@github-actions github-actions bot temporarily deployed to pr-4821 April 26, 2024 12:20 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4821 April 30, 2024 10:16 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4821 May 7, 2024 21:18 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4821 May 14, 2024 09:01 Destroyed
@Droniu Droniu merged commit 0589970 into main May 16, 2024
14 of 15 checks passed
@Droniu Droniu deleted the merx-342-refund-payments branch May 16, 2024 14:09
karola312 pushed a commit that referenced this pull request May 23, 2024
…details (#4821)

* Temp solution

* Show charge and autorized amount

* Add changeset

* Restore messages

* Improve showing amount

* Improve copy

---------

Co-authored-by: Michał Droń <droniu@droniu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants