Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old workflows, add new one for core releases #4853

Closed
wants to merge 37 commits into from

Conversation

karola312
Copy link
Member

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 97b371d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4853 May 9, 2024 12:03 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4853 May 13, 2024 09:17 Destroyed
@karola312 karola312 marked this pull request as ready for review May 13, 2024 10:35
@karola312 karola312 requested review from a team as code owners May 13, 2024 10:35
@github-actions github-actions bot temporarily deployed to pr-4853 May 13, 2024 10:36 Destroyed
Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pr-4853 May 14, 2024 09:42 Destroyed
karola312 and others added 2 commits May 15, 2024 12:47
Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pr-4853 May 15, 2024 10:51 Destroyed
Comment on lines 62 to 71
--input - <<< '{
"event_type": "open-release-pull-request",
"client_payload": {
"project": "CORE",
"environment": "SANDBOX",
"version": "$VERSION"
"details_url_to_test_run": "$DETAILS_URL_TO_TEST_RUN"
"test_status": "$TEST_STATUS"
}
}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. Use jq to prevent injections inside the JSON (and to prevent malformed JSON)
  2. The variables are in a single quotes block instead of double quotes thus they will not be expanded, example (the quotes <<< '[...] vs <<< "[...]):
$ foo=123
$ cat <<< '{"value": "$foo"}'
{"value": "$foo"}
$ cat <<< $"{\"value\": \"$foo\"}"
{"value": "123"}

@github-actions github-actions bot temporarily deployed to pr-4853 May 16, 2024 08:38 Destroyed
yellowee and others added 2 commits May 23, 2024 11:59
… customer and expiry date (#4848)

* adding staff member CRUD tests

* Fixing flaky test - TC: SALEOR_106 Issue gift card with specific customer and expiry date

* Update playwright/tests/giftCards.spec.ts

Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>

---------

Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
* change product list sort to last updated desc

* changesets
yellowee and others added 11 commits May 23, 2024 11:59
* Fixing flaky test: TC: SALEOR_87 Edit voucher Usage Limits: used in total, per customer, staff only, code used once

* adding skip to a gift card test
* Fixing flaky test - TC: SALEOR_205 Bulk delete customers

* fixing flaky gift card tests
…details (#4821)

* Temp solution

* Show charge and autorized amount

* Add changeset

* Restore messages

* Improve showing amount

* Improve copy

---------

Co-authored-by: Michał Droń <droniu@droniu.dev>
#4826)

* Get product search channel listing

* Show is product incuded in selected channels

* Disable checkbox and show info when no channels overlap

* Add changeset

* Make solution more general

* Add selected channels to other dialogs

* Update fixture

* Update changset

* Fix types

* Update mocks

* Extract messages

* Update messages

* Disable checkbox for products that are not available in selected channels (#4841)

* check if product is available in channel

* add changesets

* show message why product's disabled

* extract messages

* Unify assign product modals (#4864)

---------

Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
* wip: replace deprecated fields

* `availableForPurchaseAt`

* visibility card + cleanup

* cleanup

* check if input is valid

* add helper text

* fix 'hidden' 2nd label

* qa fixes

* Add tests and cleanup code

* fix type

* cr fixes
* show categories' ancestors

* add tests

* cleanup

* changeset

* cr fixes

* show parents when category is selected

* show only parent and grandparent category

* reverse order

* properly align input with adornment

* fix test

* improve categories display

* fix

* fix

* fix display while loading

* improve ancestor categories display

* fix tests

* show ancestors of saved category on first load

* gql cleanup

* fix tests

* update macaw

* cr fix
* (wip) Migrate Transaction Refund Datagrid to GridTable

* Add changeset

* UI improvements & reason per line modal

* Fix strict mode

* Refactor

* CR Refactor

* Improve modal UI

* Strict mode fix

* Fix navigation

* CR improvements

* Fix qtyToRefund == maxQtyToRefund

* Split components & handle ellipsis better

* Fix incorrect handling of refund lines

* Fix refs type errors
* (wip) basic order details grid

* Remove unused import

* Fix type errors

* Handle empty state

* Remove unused code

* Delegate overflow ellipsis to custom hook

* Fix tooltip conditions

* Add changeset

* Extract messages

* Fix strict error

* Change column order & add avatar

* Adjust column width

* RenamesetRef function

* Fix type errors

* Refactor useOverflowDetection to single ref
* Grid persistance

* Grid persistance

* Grid persistance

* Add tests

* Grid persistance

* Grid persistance

* Grid persistance

* Grid persistance

* Handle apollo cache

* Handle apollo cache

* Static comes first

* Update kind-dolphins-dance.md

* Fix typo, add comment with context
* Fix workflow for release PR

* add changeset

* Fix workflow for release PR

* add version without hash
yellowee and others added 14 commits June 3, 2024 11:30
* Disable refunds for specific cases

* Handle situation where both refund types are unavailable

* Add changeset

* Strict mode fixes

* CR suggestions
* Display charged information & fix typo

* Fix paddings

* Improve validation for manual refunds

* Extract messages

* Add changeset

* Fix test

* Add test case

* Improve changeset

* Move validation logic to validation schema

* Add translation
* Apply grid persistance on other views

* Create beige-ducks-matter.md

* Update beige-ducks-matter.md
… html tags and &nbsp; (#4887)

* Improve description in product datagrid

* Add changeset

* Fix typo

* Remove comment

* Cut too long description
#4895)

* Enable standard refunds for orders where all lines have been refunded

* Remove unused code

* Extract messages

* Add changeset
…R_198, SALEOR_106 (#4880)

* fixing TC: SALEOR_59

* fixing TC: SALEOR_205

* fixing TC: SALEOR_198

* fixing TC: SALEOR_106
#4881)

* Display pending manual refunds

* Stop displaying refund creator avatar when it cannot be determined

* Strict mode fix

* Changeset

* Split function into smaller parts

* Improve null handling
* Change API_URI to API_URL

* Create few-cars-beg.md

* Change API_URI to API_URL

!Q

zsh:1: command not found: q
e
* Improve copies

* Move see docs to newline

* Extract messages

* Changeset

* Fix test

* Improve sidebar consistency on manual refund view

* Fix test

* Extract messages
* Fix show loader when data from cache

* Add changeset

* Update changeset

* Update tests

* Handle loading in money input
…und view (#4912)

* Fix formatting for problematic floats

* Add test case

* Add changeset
@karola312 karola312 marked this pull request as draft June 3, 2024 09:36
@karola312 karola312 closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants