-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old workflows, add new one for core releases #4853
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 97b371d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NyanKiyoshi
reviewed
May 13, 2024
Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
NyanKiyoshi
reviewed
May 14, 2024
Co-authored-by: Mikail <6186720+NyanKiyoshi@users.noreply.github.com>
NyanKiyoshi
reviewed
May 15, 2024
Comment on lines
62
to
71
--input - <<< '{ | ||
"event_type": "open-release-pull-request", | ||
"client_payload": { | ||
"project": "CORE", | ||
"environment": "SANDBOX", | ||
"version": "$VERSION" | ||
"details_url_to_test_run": "$DETAILS_URL_TO_TEST_RUN" | ||
"test_status": "$TEST_STATUS" | ||
} | ||
}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- Use
jq
to prevent injections inside the JSON (and to prevent malformed JSON) - The variables are in a single quotes block instead of double quotes thus they will not be expanded, example (the quotes
<<< '[...]
vs<<< "[...]
):
$ foo=123
$ cat <<< '{"value": "$foo"}'
{"value": "$foo"}
$ cat <<< $"{\"value\": \"$foo\"}"
{"value": "123"}
… customer and expiry date (#4848) * adding staff member CRUD tests * Fixing flaky test - TC: SALEOR_106 Issue gift card with specific customer and expiry date * Update playwright/tests/giftCards.spec.ts Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com> --------- Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
* change product list sort to last updated desc * changesets
* Fixing flaky test: TC: SALEOR_87 Edit voucher Usage Limits: used in total, per customer, staff only, code used once * adding skip to a gift card test
* Fixing flaky test - TC: SALEOR_205 Bulk delete customers * fixing flaky gift card tests
…details (#4821) * Temp solution * Show charge and autorized amount * Add changeset * Restore messages * Improve showing amount * Improve copy --------- Co-authored-by: Michał Droń <droniu@droniu.dev>
#4826) * Get product search channel listing * Show is product incuded in selected channels * Disable checkbox and show info when no channels overlap * Add changeset * Make solution more general * Add selected channels to other dialogs * Update fixture * Update changset * Fix types * Update mocks * Extract messages * Update messages * Disable checkbox for products that are not available in selected channels (#4841) * check if product is available in channel * add changesets * show message why product's disabled * extract messages * Unify assign product modals (#4864) --------- Co-authored-by: Wojciech Mista <wojciech.mista@hotmail.com>
* wip: replace deprecated fields * `availableForPurchaseAt` * visibility card + cleanup * cleanup * check if input is valid * add helper text * fix 'hidden' 2nd label * qa fixes * Add tests and cleanup code * fix type * cr fixes
* show categories' ancestors * add tests * cleanup * changeset * cr fixes * show parents when category is selected * show only parent and grandparent category * reverse order * properly align input with adornment * fix test * improve categories display * fix * fix * fix display while loading * improve ancestor categories display * fix tests * show ancestors of saved category on first load * gql cleanup * fix tests * update macaw * cr fix
* (wip) Migrate Transaction Refund Datagrid to GridTable * Add changeset * UI improvements & reason per line modal * Fix strict mode * Refactor * CR Refactor * Improve modal UI * Strict mode fix * Fix navigation * CR improvements * Fix qtyToRefund == maxQtyToRefund * Split components & handle ellipsis better * Fix incorrect handling of refund lines * Fix refs type errors
* (wip) basic order details grid * Remove unused import * Fix type errors * Handle empty state * Remove unused code * Delegate overflow ellipsis to custom hook * Fix tooltip conditions * Add changeset * Extract messages * Fix strict error * Change column order & add avatar * Adjust column width * RenamesetRef function * Fix type errors * Refactor useOverflowDetection to single ref
* Grid persistance * Grid persistance * Grid persistance * Add tests * Grid persistance * Grid persistance * Grid persistance * Grid persistance * Handle apollo cache * Handle apollo cache * Static comes first * Update kind-dolphins-dance.md * Fix typo, add comment with context
* Fix workflow for release PR * add changeset * Fix workflow for release PR * add version without hash
* Disable refunds for specific cases * Handle situation where both refund types are unavailable * Add changeset * Strict mode fixes * CR suggestions
* Display charged information & fix typo * Fix paddings * Improve validation for manual refunds * Extract messages * Add changeset * Fix test * Add test case * Improve changeset * Move validation logic to validation schema * Add translation
* Apply grid persistance on other views * Create beige-ducks-matter.md * Update beige-ducks-matter.md
… html tags and (#4887) * Improve description in product datagrid * Add changeset * Fix typo * Remove comment * Cut too long description
#4895) * Enable standard refunds for orders where all lines have been refunded * Remove unused code * Extract messages * Add changeset
…R_198, SALEOR_106 (#4880) * fixing TC: SALEOR_59 * fixing TC: SALEOR_205 * fixing TC: SALEOR_198 * fixing TC: SALEOR_106
#4881) * Display pending manual refunds * Stop displaying refund creator avatar when it cannot be determined * Strict mode fix * Changeset * Split function into smaller parts * Improve null handling
* Change API_URI to API_URL * Create few-cars-beg.md * Change API_URI to API_URL !Q zsh:1: command not found: q e
* Fix error handling * Changeset
* Improve copies * Move see docs to newline * Extract messages * Changeset * Fix test * Improve sidebar consistency on manual refund view * Fix test * Extract messages
* Fix show loader when data from cache * Add changeset * Update changeset * Update tests * Handle loading in money input
…und view (#4912) * Fix formatting for problematic floats * Add test case * Add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description