Add time to publication date and remove deprecated date fields #4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: fa14a55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Do we still need to fill the old date fields ( |
Droniu
previously approved these changes
May 13, 2024
|
@mirekm No, Saleor syncs old fields with new fields 馃檪 |
andrzejewsky
previously approved these changes
May 13, 2024
Droniu
previously approved these changes
May 14, 2024
Cloud11PL
force-pushed
the
MERX-394-publication-date-time
branch
from
31fef83
to
3b3559b
Compare
Droniu
previously approved these changes
May 15, 2024
| <RadioGroup.Item id={`isPublished-true`} value="true"> | ||
| <Box display="flex" __alignItems="baseline" gap={2}> | ||
| <Text>{messages.visibleLabel}</Text> | ||
| {isPublished && publishedAt && Date.parse(publishedAt) < dateNow && ( |
There was a problem hiding this comment.
this condition is a little difficult to read, i'd extract it but it's a nitpick really - up to you
Comment on lines
230
to
232
| {isAvailableForPurchase && | ||
| availableForPurchaseAt && | ||
| Date.parse(availableForPurchaseAt) < dateNow && ( |
andrzejewsky
previously approved these changes
May 15, 2024
Droniu
approved these changes
May 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
andrzejewsky
approved these changes
May 17, 2024
karola312
pushed a commit
that referenced
this pull request
May 23, 2024
* wip: replace deprecated fields * `availableForPurchaseAt` * visibility card + cleanup * cleanup * check if input is valid * add helper text * fix 'hidden' 2nd label * qa fixes * Add tests and cleanup code * fix type * cr fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
availableForPurchase->availableForPurchaseAtpublicationDate->publishedAtDate->DateTimeWhat type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description