Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid persistance #4862

Merged
merged 15 commits into from
May 22, 2024
Merged

Grid persistance #4862

merged 15 commits into from
May 22, 2024

Conversation

andrzejewsky
Copy link
Member

What type of PR is this?

  • 馃拝 Refactor
  • 馃専 Feature
  • 馃敟 Bug Fix
  • 馃敥 Maintenance
  • 馃洜 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@andrzejewsky andrzejewsky requested a review from a team as a code owner May 14, 2024 14:40
Copy link

changeset-bot bot commented May 14, 2024

馃 Changeset detected

Latest commit: 0389713

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4862 May 14, 2024 14:43 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4862 May 15, 2024 13:44 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4862 May 16, 2024 14:28 Destroyed
Droniu
Droniu previously approved these changes May 17, 2024
Cloud11PL
Cloud11PL previously approved these changes May 17, 2024
@github-actions github-actions bot temporarily deployed to pr-4862 May 17, 2024 12:47 Destroyed
}: UseColumnsProps) => {
const [dynamicColumns, updateDynamicColumns] = React.useState<AvailableColumn[] | null>(null);

const { columns: persistedColumns, update } = usePersistance(gridName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const { columns: persistedColumns, update } = usePersistance(gridName);
const { columns: persistedColumns, update: updatePersistedColumns } = usePersistance(gridName);

@andrzejewsky andrzejewsky merged commit 4c919c1 into main May 22, 2024
10 of 11 checks passed
@andrzejewsky andrzejewsky deleted the merx-355-grid-persistance branch May 22, 2024 10:40
karola312 pushed a commit that referenced this pull request May 23, 2024
* Grid persistance

* Grid persistance

* Grid persistance

* Add tests

* Grid persistance

* Grid persistance

* Grid persistance

* Grid persistance

* Handle apollo cache

* Handle apollo cache

* Static comes first

* Update kind-dolphins-dance.md

* Fix typo, add comment with context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants