Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Fix tests for SALEOR_1801, SALEOR_1802 & SALEOR_3002 (#4852) cherrypick to 3.17 #4863

Closed
wants to merge 1 commit into from

Conversation

michalina-graczyk
Copy link
Member

  • Add fixes

  • WIP

  • wip

  • Added waiting for:

  • product being available in search
  • product variant being set to onSale

Resolves issues with

  • Unable to find product while assigning from discounts
  • Checking discounted value too quickly before the sale got processed.
  • Revert package-lock.json

  • Add missing LB

  • Add changeset

  • Add quick fix for SALEOR_3002


What type of PR is this?

  • 馃拝 Refactor
  • 馃専 Feature
  • 馃敟 Bug Fix
  • 馃敥 Maintenance
  • 馃洜 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

* Add fixes

* WIP

* wip

* Added waiting for:
- product being available in search
- product variant being set to onSale

Resolves issues with
- Unable to find product while assigning from discounts
- Checking discounted value too quickly before the sale got processed.

* Revert package-lock.json

* Add missing LB

* Add changeset

* Add quick fix for SALEOR_3002

---------

Co-authored-by: wojteknowacki <wojciech.nowacki@saleor.io>
@michalina-graczyk michalina-graczyk requested a review from a team as a code owner May 15, 2024 07:45
@michalina-graczyk michalina-graczyk requested review from andrzejewsky and poulch and removed request for a team May 15, 2024 07:45
Copy link

changeset-bot bot commented May 15, 2024

馃 Changeset detected

Latest commit: 61d5ac0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

This pull request is stale because it has been open 14 days with no activity.

@github-actions github-actions bot added the stale label May 30, 2024
Copy link

github-actions bot commented Jun 1, 2024

This PR request has been closed because it has been stalled for 2 days with no activity. You are still welcome to reopen it and continue from where you finished. Best regards Saleor team

@github-actions github-actions bot closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant