Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade dev dependencies #2109

Merged
merged 10 commits into from Dec 2, 2020
Merged

chore: Upgrade dev dependencies #2109

merged 10 commits into from Dec 2, 2020

Conversation

pmdartus
Copy link
Member

@pmdartus pmdartus commented Nov 27, 2020

Details

This PR upgrade all the outdated devDependencies.

Note: This PR doesn't upgrade @babel/core. The following change babel/babel#12391 introduces a regression to the test suite. I am still working on a small repro case to open a bug on Babel.

Does this PR introduce breaking changes?

  • No, it does not introduce breaking changes.

If yes, please describe the impact and migration path for existing applications.

The PR fulfills these requirements:

  • Have tests for the proposed changes been added? ✅
  • Have you followed these instructions to clearly describe the issue being fixed or feature enhanced? ✅

@salesforce-best-lwc-internal
Copy link

🥳 Performance Improvement

Best has detected that there is a 8.9% performance improvement across your benchmarks.

Please click here to see more details.

Click to view significantly changed benchmarks

@lwc/engine-dom

✅ Improvements base (101624b) target (803b9d3) trend
ss-slot-create-container.benchmark/benchmark-slot-ss/synthetic-shadow-create 265.98 (± 3.56ms) 232.33 (± 1.76ms) -33.6ms (12.7%)
ss-slot-update-component-with-slot.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-component-with-slot 26.14 (± 0.82ms) 23.65 (± 0.53ms) -2.5ms (9.5%)
ss-slot-update-container-template.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-container-template 27.96 (± 0.71ms) 23.57 (± 0.81ms) -4.4ms (15.7%)
ss-slot-update-slotted-content.benchmark/benchmark-slot-ss/synthetic-shadow-slot-update-slotted-content 194.10 (± 7.09ms) 179.10 (± 6.45ms) -15.0ms (7.7%)
table-append-1k.benchmark/benchmark-table/append/1k 278.88 (± 2.42ms) 241.19 (± 2.79ms) -37.7ms (13.5%)
table-clear-1k.benchmark/benchmark-table/clear/1k 16.89 (± 0.19ms) 13.69 (± 0.22ms) -3.2ms (18.9%)
table-create-10k.benchmark/benchmark-table/create/10k 1448.51 (± 14.73ms) 1283.83 (± 16.03ms) -164.7ms (11.4%)
table-create-1k.benchmark/benchmark-table/create/1k 172.72 (± 1.25ms) 143.15 (± 1.60ms) -29.6ms (17.1%)
table-update-10th-1k.benchmark/benchmark-table/update-10th/1k 148.50 (± 2.08ms) 132.19 (± 2.86ms) -16.3ms (11.0%)
tablecmp-append-1k.benchmark/benchmark-table-component/append/1k 386.94 (± 2.25ms) 351.51 (± 2.78ms) -35.4ms (9.2%)
tablecmp-clear-1k.benchmark/benchmark-table-component/clear/1k 9.70 (± 0.13ms) 6.12 (± 0.13ms) -3.6ms (37.0%)
tablecmp-create-10k.benchmark/benchmark-table-component/create/10k 2167.68 (± 14.48ms) 1925.41 (± 12.38ms) -242.3ms (11.2%)
tablecmp-create-1k.benchmark/benchmark-table-component/create/1k 252.81 (± 1.31ms) 219.68 (± 1.96ms) -33.1ms (13.1%)
tablecmp-update-10th-1k.benchmark/benchmark-table-component/update-10th/1k 129.44 (± 1.22ms) 112.52 (± 1.39ms) -16.9ms (13.1%)
wc-append-1k.benchmark/benchmark-table-wc/append/1k 513.92 (± 10.96ms) 480.23 (± 11.39ms) -33.7ms (6.6%)
wc-clear-1k.benchmark/benchmark-table-wc/clear/1k 26.82 (± 0.36ms) 21.89 (± 0.39ms) -4.9ms (18.3%)
wc-create-10k.benchmark/benchmark-table-wc/create/10k 3229.07 (± 39.02ms) 3019.24 (± 24.83ms) -209.8ms (6.5%)
wc-create-1k.benchmark/benchmark-table-wc/create/1k 367.37 (± 1.44ms) 335.19 (± 1.96ms) -32.2ms (8.8%)
wc-update-10th-1k.benchmark/benchmark-table-wc/update-10th/1k 130.46 (± 0.91ms) 115.38 (± 0.56ms) -15.1ms (11.6%)

@lwc/engine-server

✅ Improvements base (101624b) target (803b9d3) trend
table-render-10k.benchmark/benchmark-table/render/10k 509.98 (± 11.37ms) 460.25 (± 26.58ms) -49.7ms (9.8%)
tablecmp-render-10k.benchmark/benchmark-table-component/render/10k 1150.65 (± 20.33ms) 1000.36 (± 83.19ms) -150.3ms (13.1%)

@pmdartus pmdartus merged commit 792323b into master Dec 2, 2020
@pmdartus pmdartus deleted the pmdartus/upgrade branch December 2, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants