-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): handle symbol properties for dynamic values #3895
fix(compiler): handle symbol properties for dynamic values #3895
Conversation
All the Karma tests are timing out since @seckardt isn't an LWC collaborator. |
@pmdartus I had hoped GitHub Actions had a generic solution for this, but if they do, I haven't found it yet. I just open duplicate PRs to force CI to run. 😞 |
packages/@lwc/babel-plugin-component/src/decorators/wire/transform.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Just a few minor suggestions, see comments above.
d779ef8
to
520ce9f
Compare
520ce9f
to
710c39a
Compare
Looking into it further, computed properties actually support all kinds of literals: { [1]: 2 }
{ [/foo/]: 2 }
{ [null]: 2 } We don't need to be pedantic about this, though. I'll open a separate PR to handle these in |
Thanks a lot! |
Details
Fix for issue #3892.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item