chore: weekly dependencies update #3896
Merged
+808
−910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
reviewed
Dec 11, 2023
| @@ -28,7 +28,8 @@ | |||
| "@best/runner-remote": "^10.0.0", | |||
| "folder-hash": "4.0.4", | |||
| "markdown-table": "^3.0.3", | |||
| "tachometer": "0.5.10" | |||
| "tachometer": "0.5.10", | |||
| "chromedriver": "^119.0.0" | |||
There was a problem hiding this comment.
@ravijayaramappa Let's not add this dependency for everyone using this project. Otherwise it will break when you run Tachometer tests locally, because you probably have Chrome 120+ installed.
Here is my fix: #3897
There was a problem hiding this comment.
That is a good point. Approved your PR. Will revert this change.
ravijayaramappa
force-pushed
the
ravi/master/weekly-dependencies
branch
from
c414aa9 to
ce70f20
Compare
nolanlawson
reviewed
Dec 11, 2023
| @@ -7,6 +7,7 @@ node_modules/ | |||
| coverage/ | |||
| .idea/ | |||
| .project/ | |||
| .nx | |||
There was a problem hiding this comment.
Is this something NX added in v17?
There was a problem hiding this comment.
That's right. https://github.com/nrwl/nx/releases/tag/17.0.0
core: update default cache directory to .nx/cache (nrwl/nx#19536)
I tried using the cacheDirectory option, but the .nx/cache directory still gets used.
nolanlawson
approved these changes
Dec 11, 2023
ravijayaramappa
force-pushed
the
ravi/master/weekly-dependencies
branch
from
ce70f20 to
d473a1f
Compare
ravijayaramappa
force-pushed
the
ravi/master/weekly-dependencies
branch
from
d473a1f to
a523107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Routine update of dependencies
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-14646095