Fix dupe_check for Bazel 7 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized now that this change requires Bazel 6 or newer due to the rules_python package. @plaird any thoughts on this? Is it a requirement to support Bazel 5 for rules_spring? |
|
We can go with Bazel 6. Users of older Bazels can refer to an older commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
As far as I can tell the problem comes from bazelbuild/bazel#16303
Depending on the executable directly solves this issue, as well as being easier to understand (for me, at least)
Depending on rules_python directly might actually not be necessary but from what I've read it's the best practice as there seems to be ongoing work on moving the python rules out from Bazel itself.
Suggestions are welcome!