Clean up cookie creation #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
Mar 13, 2024
wjhsf
force-pushed
the
cleaner-cookie-creation
branch
from
1b57177
to
b11e6a5
Compare
colincasey
approved these changes
Mar 14, 2024
wjhsf
commented
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the props on
Cookieall have| undefined, even though none of them actually ever useundefinedas a value. If we get rid of| undefined, though, we get a TypeScript error complaining that the prop is not definitively assigned in the constructor. This is because we useObject.assignto initialize props, and I guess TypeScript just can't quite handle that. So, to get rid ofundefinedas a false possible value, we have to manually assign every prop. A bit more verbose, but not a significant change.Additionally, the cookie constructor options are identical to the props of
Cookie, excluding the methods, so I changed the type from explicitly listing everything to just a mapped type, for simpler maintenance. I wasn't sure if that would be a good idea, because sometimes mapped types get mangled, but the result type is still readable, so I think it's fine.nb: This was originally part of #377, but has been split out for easier review.