Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add tsx support #1021

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

remidewitte
Copy link
Contributor

Happy to see Shinigami92 taking care of this tool ! Thanks.

The PR is far for complete but it is a minimal working patch to use tsx instead of ts-node.

It might not be wanted but it makes the -j ts argument not required.

@Shinigami92 Shinigami92 added the c: feature Request for new feature label Mar 7, 2024
@Shinigami92 Shinigami92 modified the milestones: v7.0, v7.x Mar 7, 2024
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Mar 7, 2024
@Shinigami92
Copy link
Collaborator

It is indeed planned to support tsx 😃
But I would also like to allow ts-node as well

However, you should implement it in that way, that tsx takes preference over ts-node

Please note that I'm currently mostly in the migration process of adding coverage tests. Also I want to migrate the cli to a TypeScript file that is also covered by unit-tests (which is not right now ⚠️)

@Shinigami92 Shinigami92 changed the title Use tsx instead of ts-node feat(cli): add tsx support Mar 7, 2024
@Shinigami92 Shinigami92 added the needs rebase There is a merge conflict label Apr 5, 2024
@Shinigami92
Copy link
Collaborator

Hey @remidewitte
I refactored the bin/node-pg-migrate.ts file a bit and it is now checked with TypeScript.
Please rebase your work and try to keep ts-node alongside tsx.

@remidewitte
Copy link
Contributor Author

Hey @remidewitte I refactored the bin/node-pg-migrate.ts file a bit and it is now checked with TypeScript. Please rebase your work and try to keep ts-node alongside tsx.

I just realized I missed your reply. I will have a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature needs rebase There is a merge conflict p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants