Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(casts): support create and drop cast #942

Merged
merged 15 commits into from
Apr 25, 2024
Merged

feat(casts): support create and drop cast #942

merged 15 commits into from
Apr 25, 2024

Conversation

aschrab
Copy link
Contributor

@aschrab aschrab commented Sep 11, 2023

No description provided.

@Shinigami92 Shinigami92 added the c: feature Request for new feature label Apr 5, 2024
@Shinigami92 Shinigami92 added this to the v7.x milestone Apr 5, 2024
@Shinigami92 Shinigami92 self-requested a review April 5, 2024 22:22
@Shinigami92
Copy link
Collaborator

I will plan this for v7.1

@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Apr 5, 2024
@Shinigami92 Shinigami92 changed the title Add support for migrations to add or drop casts feat(casts): support create and drop cast Apr 24, 2024
@Shinigami92 Shinigami92 marked this pull request as draft April 24, 2024 07:13
@Shinigami92
Copy link
Collaborator

  • Missing tests (unit and integration)
  • Need improve refactoring

@Shinigami92
Copy link
Collaborator

Coverage Tests need to be performed manually now, as CodeCov is still not enabled. There is an issue that prevents currently coverage execution from forks.

@Shinigami92
Copy link
Collaborator

Needs integration tests and a general check if all arguments are passed correctly
(e.g. functionName is now of type Name instead of just string)

@Shinigami92
Copy link
Collaborator

There is currently a bug with cockroach github action
It tries to install wait-for-it but cant, cause Clearsigned file isn't valid, got 'NOSPLIT' (does the network require authentication?) by ubuntu, jammy

I will wait a bit, maybe it fixes itself after some time

@Shinigami92
Copy link
Collaborator

github issue resolved itself

  • missing entry in docs readme

@Shinigami92 Shinigami92 marked this pull request as ready for review April 25, 2024 08:21
@Shinigami92 Shinigami92 merged commit ee76beb into salsita:main Apr 25, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92 Shinigami92 is a code owner

Assignees

@aschrab aschrab

Labels
c: feature Request for new feature p: 1-normal Nothing urgent
Projects
None yet
Milestone
v7.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aschrab @Shinigami92