[master] Fix config.items return value

[vzhestkov]

What does this PR do?

Fix return value of config.items to prevent not expected return values.

Previous Behavior

Could return the following instead of the proper dict:

demo.example.org:
    <salt.loader.context.NamedLoaderContext object at 0x7f31461b80a0>

New Behavior

Return the expected dict output

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

• Docs
• Changelog - https://docs.saltproject.io/en/master/topics/development/changelog.html
• Tests written/updated

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

[lkubb]

I don't think it's always a NamedLoaderContext. See below.

outdated suggestion

``` ```suggestion try: return __opts__.value() except AttributeError: return __opts__ ```

[vzhestkov]

Do you know in what cases it could be not NamedLoaderContext? As far as I know __opts__ is populated with LazyLoader and to be fair I'm not sure if it can push something different there.

[lkubb]

Tbh now I'm not sure anymore if what I said is correct. I looked up what I remembered when writing the above, but it might have been Salt-SSH-specific only. Sorry for the noise! :)

In general, I think one of the cases where this might happen in a regular module is if the dunder is initialized to a dict during module import in the top-level module code, but that's not the case here (on the contrary).

Edit: So in this module __opts__is specifically initialized to be a NamedLoaderContext, but once I comment out

salt/salt/modules/config.py

Line 40 in aad71fd

__opts__ = __salt_loader__.named_context("__opts__")

it turns into a dict. Someone with more familiarity with the loader will probably be able to shed some light on this.