Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add skip_install #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CryogenicPlanet
Copy link

Already has a skip_build option I think a skip_install in the same vain can be useful for people who want to cache package installation or use something like pnpm

It is a very minor change hence didn't make a detailed PR

@imolorhe
Copy link

Exactly what I need for #61

imolorhe added a commit to altair-graphql/altair that referenced this pull request Apr 21, 2021
Using CryogenicPlanet/action-electron-builder@v2 temporarily,
until samuelmeuli/action-electron-builder#60 is
merged.
@CryogenicPlanet
Copy link
Author

As a temporary fix @imolorhe you can directly use that repo.

Also adding closes #61

- name: Build/release Electron app
        uses: cryogenicplanet/action-electron-builder@v2
        with:
          # GitHub token, automatically provided to the action
          # (No need to define this secret in the repo settings)
          github_token: ${{ secrets.github_token }}
          skip_install: true

          # If the commit is tagged with a version (e.g. "v1.0.0"),
          # release the app after building
          release: ${{ startsWith(github.ref, 'refs/tags/v') }}

@imolorhe
Copy link

imolorhe commented Apr 21, 2021

@CryogenicPlanet already did 😄 I needed it urgently altair-graphql/altair@13f6d20 It works perfectly. Thank you

@markxoe
Copy link

markxoe commented May 29, 2021

Any way of getting this merged soon? 😄

@mifi
Copy link

mifi commented Jul 22, 2022

@samuelmeuli do you need help maintaining this project? I'll volunteer

@andirsun
Copy link

We are using this action at my company so We can maintain it as well

@imyanice
Copy link

If you wish to use an updated version & see your PR accepted go here: https://github.com/Yan-Jobs/action-electron-builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants