feat: downlevel type arguments in typeof #83
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
commented
Nov 27, 2022
|
|
||
| ```ts | ||
| type N = any; | ||
| ``` |
There was a problem hiding this comment.
I'm struggling to write a good semantics part, not sure about the chosen approach
There was a problem hiding this comment.
The current architecture of downlevel-dts is syntax-only so it doesn't have the information to make this work. If the tool had type information, it could use an inlining strategy: write out the signature type after instantiation.
Constructing a full program to collection type information would make downlevel-dts much slower and more fragile. So I think it's better not to downlevel this construction.
There was a problem hiding this comment.
... and to avoid usage of typeof foo<T> in the original code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.