Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when literal is string #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix when literal is string #2

wants to merge 1 commit into from

Conversation

hkc452
Copy link

@hkc452 hkc452 commented Jun 8, 2021

fix when the type of Literal Expression is string

@sandersn
Copy link
Owner

sandersn commented Jun 8, 2021

It looks like you're trying the exercise to add string literals. A couple of comments:

  1. I haven't figured out how people should try the exercises. I can look at PRs here if you want.
  2. What you have is the addition you need for the checker, but for new syntax like string literals, you'll also need substantial additions in the types, lexer and parser.

@Zzzen
Copy link

Zzzen commented Jul 10, 2021

Maybe add some test & baseline files so beginners can try it out themselves? And enable discussion here?

@Zzzen
Copy link

Zzzen commented Jul 10, 2021

I guess documentation on how to debug tests on vscode would be helpful.

@sandersn
Copy link
Owner

Those are both really good ideas. I could make a branch that adds the tests and baselines and then people could fork from that branch.

I haven't actually debugged mini-typescript -- just console.log debugging -- so it'll take me some fiddling to get that set up, but it's definitely needed.

@sandersn
Copy link
Owner

#12 kicks off discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants