Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required pytest version is broken on Python 3.10 #2263

Closed
prryplatypus opened this issue Oct 3, 2021 · 4 comments
Closed

Required pytest version is broken on Python 3.10 #2263

prryplatypus opened this issue Oct 3, 2021 · 4 comments
Assignees

Comments

@prryplatypus
Copy link
Member

prryplatypus commented Oct 3, 2021

Describe the bug
The current version of pytest required by Sanic (5.2.1) is incompatible with Python 3.10 and throws an exception when running tests.

Expected behavior
Tests run on Python 3.10.

Additional context
A fix was released with pytest version 6.2.4. See pytest's related issue: pytest-dev/pytest#8539.

@sjsadowski
Copy link
Contributor

PEP 619 has the target date for 3.10 is 2021-10-04 (Today) so I imagine we should fix this in 21.9.X as well as for the LTS

@ahopkins
Copy link
Member

ahopkins commented Oct 4, 2021

Release is @ 17:00 UTC

After that, we will get #2257 running with whatever needed changes, and then a bump in supported versions as @sjsadowski mentioned.

@sjsadowski
Copy link
Contributor

@ahopkins quick note the GH runner seems to be interpreting "3.10" as "3.1" per the test failure here: https://github.com/sanic-org/sanic/pull/2257/checks?check_run_id=3777968217

@ahopkins
Copy link
Member

ahopkins commented Oct 4, 2021

@ahopkins quick note the GH runner seems to be interpreting "3.10" as "3.1" per the test failure here: https://github.com/sanic-org/sanic/pull/2257/checks?check_run_id=3777968217

I know. I saw that. I believe it should be using 3.10-dev. But, did not dig into it further since the release is imminent and I imagine the regular release version is not far behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants