Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 testing (and support) #2257

Merged
merged 7 commits into from Oct 28, 2021
Merged

Add Python 3.10 testing (and support) #2257

merged 7 commits into from Oct 28, 2021

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Oct 2, 2021

No description provided.

@sjsadowski
Copy link
Contributor

Note: this will close #2263 when the tests are fixed

@sjsadowski
Copy link
Contributor

Note: this bumps to pytest 6.2.5 due to pytest-dev/pytest#8494

@sjsadowski sjsadowski requested a review from a team October 24, 2021 22:53
@sjsadowski
Copy link
Contributor

@sanic-org/framework So this currently (correctly) fails on 3.10, but I don't want to introduce fixes for 3.10 in this branch. Could you take a look and let me know if you're okay with us a) marking 3.10 tests as not required so that they don't block merging going forward and then b) opening an issue to correct for issues with 3.10 and c) merging after the new issue is created?

@codeclimate
Copy link

codeclimate bot commented Oct 28, 2021

Code Climate has analyzed commit 015a0dc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (86% is the threshold).

This pull request will bring the total coverage in the repository to 86.7% (0.0% change).

View more on Code Climate.

@sjsadowski sjsadowski merged commit f5bd6e3 into main Oct 28, 2021
@sjsadowski sjsadowski deleted the python3.10 branch October 28, 2021 18:41
@sjsadowski sjsadowski restored the python3.10 branch October 28, 2021 18:42
@ahopkins ahopkins deleted the python3.10 branch October 28, 2021 18:44
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Administratively merging because @vltr and @ahopkins are the release managers, and @ahopkins is originator of the PR

* Add Python 3.10 testing (and support)

* fixed py310 tox environment for windows, quoted '3.10' in python-310 tests to avoid numeric compression

* updated tox.ini for py310

* quoted the rest of the bare 3.10 references in the workflows

* Issue with pytest requires version bump to 6.2.5 for python 3.10

Co-authored-by: Stephen Sadowski <stephen.sadowski@sjsadowski.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants