New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove loop parameter where necessary because it is deprecated in 3.10 #2293

Closed

sjsadowski opened this issue Oct 28, 2021 · 1 comment

Assignees

Labels

breaking necessary

Contributor

sjsadowski commented Oct 28, 2021

Is your feature request related to a problem? Please describe.
Problem: loop parameter deprecated in 3.10, preventing Sanic from running

Describe the solution you'd like
Do not pass the loop when unnecessary

Additional context
This is follow-up work from #2257 where the 3.10 tests are correctly failing because of the above

sjsadowski added necessary breaking hacktoberfest labels

sjsadowski self-assigned this

sjsadowski mentioned this issue

Py310 loop fixup #2294

Merged

Contributor Author

sjsadowski commented Oct 29, 2021

Closed by #2294

sjsadowski closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment