Py310 loop fixup #2294
Merged
Py310 loop fixup #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oval in 3.10, and optional supply in 3.9
|
I am not sure how I'd write a test for this change. I'm open to suggestions. |
|
Resolves #2293 |
ahopkins
previously approved these changes
Oct 28, 2021
I think you would monkeypatch It is probably not a critical test though. |
ahopkins
reviewed
Oct 28, 2021
|
Code Climate has analyzed commit 36e88cd and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (86% is the threshold). This pull request will bring the total coverage in the repository to 86.7% (0.0% change). View more on Code Climate. |
ahopkins
approved these changes
Oct 28, 2021
ChihweiLHBird
pushed a commit
to ChihweiLHBird/sanic
that referenced
this pull request
Jun 1, 2022
* Fixup for 3.8+; Sanic still supports 3.7 where loop is required * Added branching statement to hanle asyncio.Event() loop parameter removal in 3.10, and optional supply in 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will handle errors thrown in asgi MockProtocol class for py310