feat: support modern bundlers browser mode #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Thanks a bunch! |
rexxars
pushed a commit
that referenced
this pull request
Aug 24, 2022
Adds tests for new runtimes: [Bun](https://bun.sh/), [Deno](https://deno.land/) and the [Edge runtime](https://edge-runtime.vercel.sh/). I wanted to add tests for node16 ESM modes as well as Cloudflare Workers and react-native maybe. But I'm out of time and it's best to get in what we have and follow up with new PRs. The Deno test is expected [to keep failing](https://github.com/sanity-io/client/runs/7849905824?check_suite_focus=true#step:5:201) until [`get-it` gets a similar](https://github.com/sanity-io/get-it/blob/7873e3fb4f38c21fe91f727f65acca250bc6c5f0/package.json#L9-L23) fix as #24
stipsan
added a commit
that referenced
this pull request
Aug 27, 2022
…ironments that bundle for the browser, such as Next.js. Remove `pkg.exports` until what we ship there is 100% compatible with the ecosystem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #13 but far less ambitious.
get-it,rxjsetc stays external).nodespecificpkg.exports.What is the point of this PR then?
It's to add a
pkg.exports.browsersso that browser targeted bundling works in modern bundlers that doesn't supportpkg.browser.What about ESM?
This PR improves that story slightly, not because the generated
sanityClient.browser.mjsisESMformatted, but only becauseesbuildthat generates it understandspkg.browsersand makes sure to usesrc/http/browserMiddleware.jsinstead ofsrc/http/nodeMiddleware.js.This means that bundlers that are currently failing to build
@sanity/clientdue to it attempting to bundleget-it/lib-node/middleware/*and its dependencies, such as skypack:will now start working again with this PR.
I'll revisit #13 once all the upstream deps are ESM. That includes the
nodepart of it as I need more time testing node 16 and its different modes with the newpkg.exports.nodeto fully understand how it works and how we should wield it.