Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add runtime tests #19

Merged
merged 27 commits into from
Aug 24, 2022
Merged

chore: add runtime tests #19

merged 27 commits into from
Aug 24, 2022

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Aug 15, 2022

Adds tests for new runtimes: Bun, Deno and the Edge runtime. I wanted to add tests for node16 ESM modes as well as Cloudflare Workers and react-native maybe. But I'm out of time and it's best to get in what we have and follow up with new PRs.

The Deno test is expected to keep failing until get-it gets a similar fix as #24

Let me know if you prefer me to comment out the Deno workflow until the test is passing.

@stipsan stipsan requested a review from rexxars August 19, 2022 02:07
@stipsan stipsan marked this pull request as ready for review August 19, 2022 02:08
@stipsan stipsan changed the title WIP chore: add runtime tests chore: add runtime tests Aug 19, 2022
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias!

I'm guessing we need to remember to update the bun lockfile whenever dependencies are updated?

@rexxars
Copy link
Member

rexxars commented Aug 24, 2022

Also, yes - I think we should disable the deno test for now until we can get it working.

@rexxars rexxars merged commit 988208d into main Aug 24, 2022
@rexxars rexxars deleted the runtimes branch August 24, 2022 22:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants