fix: replace form-urlencoded with native APIs

package.json

@@ -100,7 +100,6 @@
     "debug": "^4.3.4",
     "decompress-response": "^7.0.0",
     "follow-redirects": "^1.15.2",
-    "form-urlencoded": "^6.1.0",
     "into-stream": "^6.0.0",
     "is-plain-object": "^5.0.0",
     "is-retry-allowed": "^2.2.0",

src/middleware/urlEncoded.ts

@@ -1,10 +1,35 @@
-import encode from 'form-urlencoded'
 import {isPlainObject} from 'is-plain-object'
 
-const isBuffer = (obj: any) =>
-  !!obj.constructor &&
-  typeof obj.constructor.isBuffer === 'function' &&
-  obj.constructor.isBuffer(obj)
+import {isBuffer} from '../util/isBuffer'
+
+function encode(data: Record<string, string | Set<number | string>>): string {
+  const query = new URLSearchParams()
+
+  const nest = (name: string, _value: unknown) => {
+    const value = _value instanceof Set ? Array.from(_value) : _value
+    if (Array.isArray(value)) {
+      if (value.length) {
+        for (const index in value) {
+          nest(`${name}[${index}]`, value[index])
+        }
+      } else {
+        query.append(`${name}[]`, '')
+      }
+    } else if (typeof value === 'object' && value !== null) {
+      for (const [key, obj] of Object.entries(value)) {
+        nest(`${name}[${key}]`, obj)
+      }
+    } else {
+      query.append(name, value as string)
+    }
+  }
+
+  for (const [key, value] of Object.entries(data)) {
+    nest(key, value)
+  }
+
+  return query.toString()
+}
 
 /** @public */
 export function urlEncoded(): any {
@@ -22,12 +47,14 @@ export function urlEncoded(): any {
         return options
       }
 
-      return Object.assign({}, options, {
+      return {
+        ...options,
         body: encode(options.body),
-        headers: Object.assign({}, options.headers, {
+        headers: {
+          ...options.headers,
           'Content-Type': 'application/x-www-form-urlencoded',
-        }),
-      })
+        },
+      }
     },
   }
 }

test-deno/import_map.json

@@ -2,7 +2,6 @@
   "imports": {
     "create-error-class": "https://esm.sh/create-error-class@^3.0.2",
     "debug": "https://esm.sh/debug@^4.3.4",
-    "form-urlencoded": "https://esm.sh/form-urlencoded@^6.1.0",
     "is-plain-object": "https://esm.sh/is-plain-object@^5.0.0",
     "parse-headers": "https://esm.sh/parse-headers@^2.0.5"
   }

test/urlEncoded.test.ts

@@ -55,7 +55,8 @@ describe('urlEncoded middleware', () => {
       'obj[prop2][0]': 'elem',
       str: 'val',
       emoji: '😀',
-      set: '1,two',
+      'set[0]': '1',
+      'set[1]': 'two',
     })
   })