fix(portable-text-editor): fix missing props.value updates

sanity-io · Aug 17, 2022 · 6a5c972 · 6a5c972
1 parent 5abfe3a
commit 6a5c972
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/@sanity/portable-text-editor/src/editor/PortableTextEditor.tsx b/packages/@sanity/portable-text-editor/src/editor/PortableTextEditor.tsx
@@ -255,12 +255,15 @@ export class PortableTextEditor extends React.Component<
       this.slateInstance.maxBlocks = this.maxBlocks
     }
 
-    // Update the value if we are not subscribing to patches,
-    if (!this.props.incomingPatches$ && this.state.currentValue !== this.props.value) {
+    // Update the value directly from props if we are not subscribing to patches or in readOnly mode.
+    if (
+      (!this.props.incomingPatches$ || this.readOnly) &&
+      this.state.currentValue !== this.props.value
+    ) {
       this.syncValue()
     }
-    // Initial value sync when subscribing to patches
-    if (this.props.incomingPatches$ && this.state.currentValue === null && this.props.value) {
+    // Initial value sync
+    if (this.state.currentValue === null && this.props.value) {
       this.syncValue()
     }
   }