refactor(portable-text-editor): simplify equality test

sanity-io · Aug 17, 2022 · 9565cbd · 9565cbd
1 parent 6a5c972
commit 9565cbd
Showing 1 changed file with 7 additions and 19 deletions.
diff --git a/packages/@sanity/portable-text-editor/src/editor/PortableTextEditor.tsx b/packages/@sanity/portable-text-editor/src/editor/PortableTextEditor.tsx
@@ -329,25 +329,13 @@ export class PortableTextEditor extends React.Component<
     }
 
     const isEqualToValue = !(this.props.value || []).some((blk, index) => {
-      if (this.slateInstance.isTextBlock(blk)) {
-        const compareBlock = toSlateValue(
-          [blk],
-          {portableTextFeatures: this.portableTextFeatures},
-          KEY_TO_SLATE_ELEMENT.get(this.slateInstance)
-        )[0]
-        if (!isEqual(compareBlock, this.slateInstance.children[index])) {
-          return true
-        }
-      } else {
-        const slateBlock = this.slateInstance.children[index]
-        if (
-          !slateBlock ||
-          (slateBlock &&
-            'value' in slateBlock &&
-            !isEqual(blk, {_key: slateBlock._key, _type: slateBlock._type, ...slateBlock.value}))
-        ) {
-          return true
-        }
+      const compareBlock = toSlateValue(
+        [blk],
+        {portableTextFeatures: this.portableTextFeatures},
+        KEY_TO_SLATE_ELEMENT.get(this.slateInstance)
+      )[0]
+      if (!isEqual(compareBlock, this.slateInstance.children[index])) {
+        return true
       }
       return false
     })