fix: ignore blocks inside list items #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
juice49
approved these changes
Aug 9, 2022
skogsmaskin
approved these changes
Aug 12, 2022
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
rexxars
force-pushed
the
html-to-blocks-nesting
branch
from
dc94ca2
to
8e18e7a
Compare
bjoerge
pushed a commit
that referenced
this pull request
Sep 21, 2022
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
bjoerge
pushed a commit
that referenced
this pull request
Sep 23, 2022
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
bjoerge
pushed a commit
that referenced
this pull request
Sep 26, 2022
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
bjoerge
pushed a commit
that referenced
this pull request
Sep 28, 2022
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
juice49
pushed a commit
that referenced
this pull request
Dec 15, 2022
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
rexxars
pushed a commit
that referenced
this pull request
Dec 16, 2022
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element.
With this change blocks are ignored, and block children are added directly to the listItem instead.
What to review
Testcase should cover the changes introduced; from the code comment it seems like this usecase was already accounted for, but was checking element tag name instead of parent tag name.
Notes for release
[@sanity/block-tools] Blocks inside list items are now ignored. Child element will be added directly to the list item instead.