fix(block-tools): ignore blocks inside list items (#3492) #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element. With this change blocks are ignored, and block children are added directly to the listItem instead.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
skogsmaskin
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix has previously been released in v2. There's some work to add it to v3 in the chore/sc-21163/cherry-pick-changes-for-v3-on-next branch, but it has not yet been merged.
This fixes a bug where p-tags (and other block elements) inside li elements where incorrectly hoisted out of the li element.
With this change blocks are ignored, and block children are added directly to the listItem instead.