Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @playwright/test to latest #5792

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

skogsmaskin
Copy link
Member

@skogsmaskin skogsmaskin commented Feb 19, 2024

Description

The Playwright version we are using currently has a bug as described here.

I got hit by it trying to pass a ref made by createRef to the mounted test component in playwright-ct. Upgrading Playwright to latest fixes the issue.

What to review

The Playwright tests work as expected.

Testing

If all the Playwright-related CI tests pass, we are good.

Notes for release

N/A

Current version has a bug as described here: microsoft/playwright#29028
@skogsmaskin skogsmaskin requested review from a team as code owners February 19, 2024 14:55
@skogsmaskin skogsmaskin requested review from pedrobonamin and ricokahler and removed request for a team February 19, 2024 14:55
Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 19, 2024 2:55pm
test-studio ✅ Ready (Inspect) Visit Preview Feb 19, 2024 2:55pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 19, 2024 2:55pm

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@playwright/experimental-ct-react@1.41.2 Transitive: environment, eval, filesystem, network, shell, unsafe +47 28 MB yurys
npm/@playwright/test@1.41.2 Transitive: environment, eval, filesystem, network, shell, unsafe +2 10.1 MB yurys

🚮 Removed packages: npm/@playwright/experimental-ct-react@1.41.0, npm/@playwright/test@1.41.0

View full report↗︎

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Feb 19, 2024 3:00 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 18s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 59s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@skogsmaskin skogsmaskin added this pull request to the merge queue Feb 19, 2024
Merged via the queue into next with commit 84a6015 Feb 19, 2024
40 checks passed
@skogsmaskin skogsmaskin deleted the chore/upgrade-playwright branch February 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants