Skip to content

Commit

Permalink
fix: CSM key order is now stable, workaround no longer necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
stipsan committed Mar 18, 2024
1 parent 3a6bd8f commit ab45ecc
Showing 1 changed file with 6 additions and 24 deletions.
30 changes: 6 additions & 24 deletions packages/react-loader/src/defineUseQuery.ts
Expand Up @@ -62,35 +62,17 @@ export function defineUseQuery({
(a: any, b: any) => {}
// */

if (!isEqual(prev.data, snapshot.data)) {
// console.log('data changed')
// debug(prev.data, snapshot.data)
if (!isEqual(prev.sourceMap, snapshot.sourceMap)) {
// console.log('sourceMap changed')
// debug(prev.sourceMap, snapshot.sourceMap)
return snapshot
}

/*
// TODO: sourceMaps reorder randomly and can't be compared in a reliable way
if (!isEqual(prev.sourceMap, snapshot.sourceMap)) {
if (
!isEqual(prev.sourceMap?.documents, snapshot.sourceMap?.documents)
) {
console.log('sourceMap.documents changed')
debug(prev.sourceMap?.documents, snapshot.sourceMap?.documents)
}
if (
!isEqual(prev.sourceMap?.mappings, snapshot.sourceMap?.mappings)
) {
console.log('sourceMap.mappings changed')
debug(prev.sourceMap?.mappings, snapshot.sourceMap?.mappings)
}
if (!isEqual(prev.sourceMap?.paths, snapshot.sourceMap?.paths)) {
console.log('sourceMap.paths changed')
debug(prev.sourceMap?.paths, snapshot.sourceMap?.paths)
}
if (!isEqual(prev.data, snapshot.data)) {
// console.log('data changed')
// debug(prev.data, snapshot.data)
return snapshot
}
// */

if (prev.error !== snapshot.error) {
// console.log('error changed', prev.error, snapshot.error)
Expand Down

0 comments on commit ab45ecc

Please sign in to comment.