Skip to content

Commit

Permalink
fix: revert vitejs#9459
Browse files Browse the repository at this point in the history
  • Loading branch information
sapphi-red committed Aug 12, 2022
1 parent 7121ee0 commit 502fadd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions packages/vite/src/node/plugins/resolve.ts
Expand Up @@ -867,8 +867,6 @@ export function resolvePackageEntry(
) {
// likely UMD or CJS(!!! e.g. firebase 7.x), prefer module
entryPoint = data.module
} else {
entryPoint = browserEntry
}
}
} else {
Expand Down
3 changes: 2 additions & 1 deletion playground/resolve/__tests__/resolve.spec.ts
Expand Up @@ -88,7 +88,8 @@ test('browser field', async () => {
expect(await page.textContent('.browser')).toMatch('[success]')
})

test('Resolve browser field even if module field exists', async () => {
// TODO: skip because #9459 is reverted
test.skip('Resolve browser field even if module field exists', async () => {
expect(await page.textContent('.browser-module1')).toMatch('[success]')
})

Expand Down

0 comments on commit 502fadd

Please sign in to comment.