Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable rollup tree-shaking #174

Merged
merged 3 commits into from
Aug 29, 2022
Merged

build: enable rollup tree-shaking #174

merged 3 commits into from
Aug 29, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Aug 17, 2022

esbuild tree-shake doesn't removes duplicate imports. So enabled rollup tree-shake

blocked by: egoist/tsup#692 merged and released

esbuild tree-shake doesn't removes duplicate imports. So enabled rollup tree-shake

blocked by: egoist/tsup#692
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #174 (221b3fc) into main (5114f95) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 221b3fc differs from pull request most recent head c33234a. Consider uploading reports for the commit c33234a to get more accurate results

@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files          56       56              
  Lines        3359     3355       -4     
  Branches      802      801       -1     
==========================================
- Hits         3337     3333       -4     
  Misses         13       13              
  Partials        9        9              
Impacted Files Coverage Δ
src/validators/BaseValidator.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

favna
favna previously approved these changes Aug 29, 2022
@favna favna enabled auto-merge (squash) August 29, 2022 19:21
@favna favna merged commit 59b9a01 into sapphiredev:main Aug 29, 2022
@imranbarbhuiya imranbarbhuiya deleted the build/enable-treeshake branch August 29, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants