feat: add node 19 support (#428)

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
sapphiredev · Dec 18, 2022 · f2d2dc6 · f2d2dc6
1 parent d836d9e
commit f2d2dc6
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 30 deletions.
diff --git a/.github/workflows/ci-build-and-test.yml b/.github/workflows/ci-build-and-test.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-10.15, macos-11, macos-12, ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, windows-2019]
+        os: [macos-10.15, macos-11, macos-12, ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022]
         node: [12, 13, 14, 15, 16, 17]
     steps:
       - name: Checkout Project
@@ -48,8 +48,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-10.15, macos-11, macos-12, ubuntu-20.04, ubuntu-22.04, windows-2019]
-        node: [18]
+        os: [macos-10.15, macos-11, macos-12, ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022]
+        node: [18, 19]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
@@ -84,7 +84,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [12, 13, 14, 15, 16, 17, 18]
+        node: [12, 13, 14, 15, 16, 17, 18, 19]
     steps:
       - name: Setup env with Node v${{ matrix.node }}
         run: |
@@ -156,7 +156,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-20.04, ubuntu-22.04]
-        node: [18]
+        node: [18, 19]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
@@ -197,7 +197,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [12, 13, 14, 15, 16, 17, 18]
+        node: [12, 13, 14, 15, 16, 17, 18, 19]
     steps:
       - name: Setup env with Node v${{ matrix.node }}
         run: |

diff --git a/.github/workflows/release-updater.yml b/.github/workflows/release-updater.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-10.15, macos-11, macos-12, ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, windows-2019]
+        os: [macos-10.15, macos-11, macos-12, ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022]
         node: [12, 13, 14, 15, 16, 17]
     steps:
       - name: Checkout Project
@@ -30,7 +30,7 @@ jobs:
           registry-url: https://registry.yarnpkg.org/
 
       - name: Install Dependencies
-        run: yarn --immutable
+        run: yarn --immutable --mode=skip-build
 
       - name: Package prebuild
         run: yarn build
@@ -48,8 +48,8 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-10.15, macos-11, macos-12, ubuntu-20.04, ubuntu-22.04, windows-2019]
-        node: [18]
+        os: [macos-10.15, macos-11, macos-12, ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022]
+        node: [18, 19]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
@@ -62,7 +62,10 @@ jobs:
           registry-url: https://registry.yarnpkg.org/
 
       - name: Install dependencies
-        run: yarn --immutable
+        run: yarn --immutable --mode=skip-build
+
+      - name: Build From Source
+        run: yarn gyp:build-from-source
 
       - name: Package prebuild
         run: yarn build
@@ -82,7 +85,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [12, 13, 14, 15, 16, 17, 18]
+        node: [12, 13, 14, 15, 16, 17, 18, 19]
     steps:
       - name: Setup env with Node v${{ matrix.node }}
         run: |
@@ -93,7 +96,10 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Install dependencies
-        run: yarn --immutable
+        run: yarn --immutable --mode=skip-build
+
+      - name: Build From Source
+        run: yarn gyp:build-from-source
 
       - name: Package prebuild
         run: yarn build
@@ -125,7 +131,10 @@ jobs:
           registry-url: https://registry.yarnpkg.org/
 
       - name: Install dependencies
-        run: yarn --immutable
+        run: yarn --immutable --mode=skip-build
+
+      - name: Build From Source
+        run: yarn gyp:build-from-source
 
       - name: Package prebuild
         run: |
@@ -150,7 +159,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-20.04, ubuntu-22.04]
-        node: [18]
+        node: [18, 19]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
@@ -163,7 +172,10 @@ jobs:
           registry-url: https://registry.yarnpkg.org/
 
       - name: Install dependencies
-        run: yarn --immutable
+        run: yarn --immutable --mode=skip-build
+
+      - name: Build From Source
+        run: yarn gyp:build-from-source
 
       - name: Package prebuild
         run: |
@@ -189,7 +201,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [12, 13, 14, 15, 16, 17, 18]
+        node: [12, 13, 14, 15, 16, 17, 18, 19]
     steps:
       - name: Setup env with Node v${{ matrix.node }}
         run: |
@@ -206,7 +218,10 @@ jobs:
           $(pwd)/aarch64-linux-musl-cross/bin/aarch64-linux-musl-gcc --version
 
       - name: Install dependencies
-        run: yarn --immutable
+        run: yarn --immutable --mode=skip-build
+
+      - name: Build From Source
+        run: yarn gyp:build-from-source
 
       - name: Package prebuild
         run: |

diff --git a/README.md b/README.md
@@ -15,14 +15,6 @@
 
 ---
 
-**_Note: We currently do not support NodeJS version 19 and above. This is currently not possible because we're using the
-[`nan`][nan] package for NodeJS internal bindings and [`nan`][nan] currently does not support NodeJS version 19 and
-above._**
-
-[nan]: https://github.com/nodejs/nan
-
----
-
 **Table of Contents**
 
 - [@sapphire/type](#sapphiretype)

diff --git a/lib/type.cc b/lib/type.cc
@@ -45,7 +45,11 @@ void GetProxyDetails(const Nan::FunctionCallbackInfo<v8::Value>& args) {
 }
 
 void Init(v8::Local<v8::Object> exports) {
-	v8::Local<v8::Context> context = exports->CreationContext();
+#if V8_MAJOR_VERSION >= 9
+	auto context = exports->GetCreationContext().ToLocalChecked();
+#else
+	auto context = exports->CreationContext();
+#endif
 
 	exports->Set(context, Nan::New("getPromiseDetails").ToLocalChecked(), Nan::New<v8::FunctionTemplate>(GetPromiseDetails)->GetFunction(context).ToLocalChecked());
 	exports->Set(context, Nan::New("getProxyDetails").ToLocalChecked(), Nan::New<v8::FunctionTemplate>(GetProxyDetails)->GetFunction(context).ToLocalChecked());

diff --git a/src/index.ts b/src/index.ts
@@ -9,9 +9,7 @@ declare namespace Internals {
 const bindingPath = find(resolve(join(__dirname, '..', './package.json')));
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
-const binding = require(bindingPath);
-
-export const { getPromiseDetails, getProxyDetails }: typeof Internals = binding;
+export const { getPromiseDetails, getProxyDetails } = require(bindingPath) as typeof Internals;
 
 /**
  * The class for deep checking Types