Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add @sapphire/node-utilities #468

Merged
merged 9 commits into from Oct 1, 2022
Merged

feat: add @sapphire/node-utilities #468

merged 9 commits into from Oct 1, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

fixes: #463

favna
favna requested changes Sep 30, 2022
View reviewed changes
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/utilities/tests/findFilesRecursively.test.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
@favna favna added the feature label Sep 30, 2022
@imranbarbhuiya imranbarbhuiya changed the title feat: add findFilesRecursively feat: add @sapphire/node-utilities Oct 1, 2022
kyranet
kyranet requested changes Oct 1, 2022
View reviewed changes
packages/node-utilities/package.json Outdated Show resolved Hide resolved
vladfrangu
vladfrangu requested changes Oct 1, 2022
View reviewed changes
packages/node-utilities/src/lib/findFilesRecursively.ts Outdated Show resolved Hide resolved
packages/node-utilities/tsup.config.ts Outdated Show resolved Hide resolved
favna
favna requested changes Oct 1, 2022
View reviewed changes
packages/node-utilities/vitest.config.ts Outdated Show resolved Hide resolved
favna
favna requested changes Oct 1, 2022
View reviewed changes
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See from issue:

Furthermore, the turbo.json should be updated to require @sapphire/utilities to be built before check-subpath is ran.

@imranbarbhuiya
Copy link
Contributor Author

imranbarbhuiya commented Oct 1, 2022 •
edited

See from issue:

Furthermore, the turbo.json should be updated to require @sapphire/utilities to be built before check-subpath is ran.

#454 isn't merged yet

@favna
Copy link
Member

favna commented Oct 1, 2022

Ah right... true

@favna favna merged commit 1606208 into sapphiredev:main Oct 1, 2022
@imranbarbhuiya imranbarbhuiya deleted the feat/gh-463 branch October 1, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranet kyranet kyranet requested changes

@favna favna favna approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
feature
Projects
Sapphire
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: port walk from subpath-updater to a proper function in utilities package
4 participants
@imranbarbhuiya @favna @vladfrangu @kyranet