Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ESLint 7.x #319

Merged
merged 1 commit into from May 9, 2020
Merged

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 8, 2020

ESLint v7.0.0 is released 馃帀


Closes #318
Unblocks airbnb/javascript#2223
Unblocks kentcdodds/eslint-config-kentcdodds#64

@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 2 times, most recently from 0de5c91 to 507a93f Compare May 8, 2020 19:59
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, assuming tests pass

.travis.yml Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 2 times, most recently from c7dc451 to fac16ca Compare May 8, 2020 20:05
@MichaelDeBoey MichaelDeBoey requested a review from ljharb May 8, 2020 20:08
@ljharb ljharb mentioned this pull request May 8, 2020
19 tasks
@ljharb
Copy link
Collaborator

ljharb commented May 8, 2020

Looks like the linter's failing

@MichaelDeBoey
Copy link
Contributor Author

@ljharb Should I delete the 'node' run? 馃
It's the same as the '14' run

@ljharb
Copy link
Collaborator

ljharb commented May 8, 2020

@MichaelDeBoey no, it's not the same; it's got the LINTONLY env var set, so that runs the linter and not the tests - none of the other jobs run the linter.

@MichaelDeBoey
Copy link
Contributor Author

@ljharb It seems like tests are already failing on master (see #320):
https://travis-ci.org/github/sarbbottam/eslint-find-rules/builds/684856897

@MichaelDeBoey MichaelDeBoey marked this pull request as draft May 8, 2020 23:44
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review May 8, 2020 23:50
@MichaelDeBoey
Copy link
Contributor Author

@ljharb All green 馃檪

@ljharb ljharb merged commit ee91070 into sarbbottam:master May 9, 2020
@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch May 9, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint v7 support
2 participants