fix: Sample code in README.md
#546
Merged
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KobeW50
changed the title
README.md for nodetail doesn't match sample imageREADME.md
sarisia
requested changes
Aug 11, 2024
Co-authored-by: Takakazu Fu <git@sarisia.cc>
Co-authored-by: Takakazu Fu <git@sarisia.cc>
|
Thanks! I didn't realize that was a thing. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample code for
nodetaildid not match the corresponding image (which is the same image as the markdown example). This PR makes the code match what is in the image. Additionally, I updated the sample code in the markdown example to be dynamic, since this can actually be used in a real scenerio.I tested my new sample code and it matches the images currently in the README:
Also, I opened a feature request regarding support for the transparent embed color.