New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUILD] Update to gradle 5.6.2 #722
Conversation
The new version fixes the duplicate classpath entries in the .classpath file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still does not work for me. Eclipse now has issues with the STF packages. This example is from /saros.stf/src/saros/stf/client/StfTestCase.java
. The issue message is "EclipseTestThread cannot be resolved to a type".
This also gets resolved by reverting this PR and the previous gradle update (402d0f2).
This issue is also happens when I try to build in Eclipse with #721.
The issue does not seem to be related to remaining deprecated build artifacts. Still happens when I clone a fresh version of the Saros repo and delete the workspace before importing. (Setup: Delete Workspace -> Clone -> Check out this branch -> And also in this setup, the issue is immediately resolved by reverting this and 402d0f2, calling |
Thank you, I was able to reproduce this issue with a fresh eclipse installation and a fresh clone. |
Ok, after trying a lot of gradle configurations and versions I realized that the EclipseTestThread is only required in stf(.test). Therefore I move the class into stf and the issue is solved... Btw. the real issue seems to be that eclipse photon introduced a new separation of test and main sources (which is configured in the .classpath file with the new attribute test=true) and this new model is adopted with the new gradle+buildship version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. 👍
Seems a bit weird to move an eclipse specific component into the STF package, but keeping it IDE independent isn't a priority with the STF yet.
All changes are generate by:
This update fixes the duplicate classpath entries in .classpath issue.