Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Update to gradle 5.6.2 #722

Merged
merged 3 commits into from Oct 17, 2019
Merged

[BUILD] Update to gradle 5.6.2 #722

merged 3 commits into from Oct 17, 2019

Conversation

m273d15
Copy link
Contributor

@m273d15 m273d15 commented Oct 14, 2019

All changes are generate by:

./gradlew wrapper --gradle-version=5.6.2

This update fixes the duplicate classpath entries in .classpath issue.

The new version fixes the duplicate
classpath entries in the .classpath file
@m273d15 m273d15 added the Area: Infrastructure Issue affecting the infrastructure to build, test and deploy Saros and its documentation label Oct 14, 2019
Copy link
Member

@tobous tobous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still does not work for me. Eclipse now has issues with the STF packages. This example is from /saros.stf/src/saros/stf/client/StfTestCase.java. The issue message is "EclipseTestThread cannot be resolved to a type".

This also gets resolved by reverting this PR and the previous gradle update (402d0f2).

This issue is also happens when I try to build in Eclipse with #721.

@tobous
Copy link
Member

tobous commented Oct 14, 2019

The issue does not seem to be related to remaining deprecated build artifacts. Still happens when I clone a fresh version of the Saros repo and delete the workspace before importing. (Setup: Delete Workspace -> Clone -> Check out this branch -> ./gradlew prepareEclipse -> open eclipse -> import from git excluding intellij package)
The issue also doesn't get resolved by subsequently calling prepareEclipse or test and reloading the package in Eclipse (using F5).

And also in this setup, the issue is immediately resolved by reverting this and 402d0f2, calling prepareEclipse again and reloading the projects in eclipse.

@m273d15
Copy link
Contributor Author

m273d15 commented Oct 17, 2019

Thank you, I was able to reproduce this issue with a fresh eclipse installation and a fresh clone.

@m273d15
Copy link
Contributor Author

m273d15 commented Oct 17, 2019

I think switching back to the previous version is the easiest fix of duplicate entries and this issue.
The reason seems to be that gradle introduced a unique on the classpath entries, but groups by the path attribute of a classpathentry. Therefore, the dependencies to saros.eclipse and saros.eclipse:testing are the same in the remove duplicate entries process.

I will open an issue in the gradle project. I don't want to use the old version forever.

Ok, after trying a lot of gradle configurations and versions I realized that the EclipseTestThread is only required in stf(.test). Therefore I move the class into stf and the issue is solved...

Btw. the real issue seems to be that eclipse photon introduced a new separation of test and main sources (which is configured in the .classpath file with the new attribute test=true) and this new model is adopted with the new gradle+buildship version.

Copy link
Member

@tobous tobous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 👍

Seems a bit weird to move an eclipse specific component into the STF package, but keeping it IDE independent isn't a priority with the STF yet.

@m273d15 m273d15 merged commit c664286 into master Oct 17, 2019
@m273d15 m273d15 deleted the pr/update_gradle_5.6.2 branch October 17, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Infrastructure Issue affecting the infrastructure to build, test and deploy Saros and its documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants