Skip to content

Commit

Permalink
Make meta.apply() an AsyncBuiltInCallable (#2152)
Browse files Browse the repository at this point in the history
Closes #2151
  • Loading branch information
nex3 committed Dec 28, 2023
1 parent 1fc740d commit f3c7be5
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 5 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -11,6 +11,8 @@

* Provide official releases for musl LibC and for Android.

* Don't crash when running `meta.apply()` in asynchronous mode.

### JS API

* Fix a bug where certain exceptions could produce `SourceSpan`s that didn't
Expand Down
3 changes: 2 additions & 1 deletion lib/src/visitor/async_evaluate.dart
Expand Up @@ -545,7 +545,8 @@ final class _EvaluateVisitor
namesInErrors: true);
_assertConfigurationIsEmpty(configuration, nameInError: true);
}, url: "sass:meta"),
BuiltInCallable.mixin("apply", r"$mixin, $args...", (arguments) async {
AsyncBuiltInCallable.mixin("apply", r"$mixin, $args...",
(arguments) async {
var mixin = arguments[0];
var args = arguments[1] as SassArgumentList;

Expand Down
2 changes: 1 addition & 1 deletion lib/src/visitor/evaluate.dart
Expand Up @@ -5,7 +5,7 @@
// DO NOT EDIT. This file was generated from async_evaluate.dart.
// See tool/grind/synchronize.dart for details.
//
// Checksum: 58ef9912c6a9d9cfe9c3f5d991f625ab1a627e7a
// Checksum: 71dcf1747eb45036d3c1b5b57bd0cd5dbe6b8e14
//
// ignore_for_file: unused_import

Expand Down
4 changes: 4 additions & 0 deletions pkg/sass_api/CHANGELOG.md
@@ -1,3 +1,7 @@
## 9.2.6

* No user-visible changes.

## 9.2.5

* No user-visible changes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/sass_api/pubspec.yaml
Expand Up @@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 9.2.5
version: 9.2.6
description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass

environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
sass: 1.69.5
sass: 1.69.6

dev_dependencies:
dartdoc: ^6.0.0
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
@@ -1,5 +1,5 @@
name: sass
version: 1.69.6-dev
version: 1.69.6
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down

0 comments on commit f3c7be5

Please sign in to comment.