Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require node>=14.0.0 #1911

Merged
merged 5 commits into from Mar 23, 2023
Merged

Require node>=14.0.0 #1911

merged 5 commits into from Mar 23, 2023

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Mar 12, 2023 •
edited

@jathak
Copy link
Member

jathak commented Mar 14, 2023

We're going to release one more version that actually does support Node 12 (see google/dart_cli_pkg#122) so that NPM picks up a compatible version for anyone still using it, but then we'll make sure to update this.

@nex3 nex3 requested a review from jathak March 20, 2023 20:54
jathak
jathak requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changelog entry for this?

@jathak jathak mentioned this pull request Mar 20, 2023
Closed
@ntkme ntkme requested a review from jathak March 20, 2023 21:18
jathak
jathak approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jathak jathak merged commit c6e7dbc into sass:main Mar 23, 2023
34 checks passed
@ntkme ntkme deleted the node-14 branch March 23, 2023 23:18
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Mar 24, 2023
@jgerigmeyer
Merge branch 'main' into browser
81e36d4 
* main:
  Require node>=14.0.0 (sass#1911)
  Add support for constants in calculations (sass#1922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ntkme @jathak