Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update behavior for sass/sass#3497 #1919

Merged
merged 1 commit into from Mar 23, 2023
Merged

Update behavior for sass/sass#3497 #1919

merged 1 commit into from Mar 23, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Mar 21, 2023

@nex3 nex3 requested a review from Goodwine March 21, 2023 01:25
@nex3 nex3 changed the title Update specs for sass/sass#3497 Update behavior for sass/sass#3497 Mar 21, 2023
Goodwine
Goodwine approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Goodwine Goodwine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have a couple questions

lib/src/value/color.dart Show resolved Hide resolved
@nex3 nex3 merged commit 216ceb7 into feature.color-4 Mar 23, 2023
@nex3 nex3 deleted the draft-1.4 branch March 23, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nex3 @Goodwine