Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into feature.color-4 #2217

Merged
merged 7 commits into from Apr 12, 2024
Merged

Merge main into feature.color-4 #2217

merged 7 commits into from Apr 12, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Apr 11, 2024

See sass/sass#3834
See sass/sass-spec#1976
[skip sass-embedded]

stof and others added 5 commits April 1, 2024 17:42
This makes several changes:

* It renames the `UPDATE_SASS_PROTOCOL` environment variable used by
  the Grinder `protobuf` task to `UPDATE_SASS_SASS_REPO` to make it
  more generic and so usable by other tasks. The previous name still
  works but is considered deprecated.

* The `pkg-npm-*` grinder tasks now respects the
  `UPDATE_SASS_SASS_REPO` environment variable. This allows repos to
  ensure that the linked language repo's version of the TypeScript
  types are used when building the npm package.

* `UPDATE_SASS_SASS_REPO=false` is set for all the `pkg-npm-*` tasks
  run by this repo, so that they will use the linked language repo's
  version of the TypeScript types.

Co-authored-by: Carlos (Goodwine) <2022649+Goodwine@users.noreply.github.com>
@nex3 nex3 requested a review from Goodwine April 11, 2024 22:58
@nex3 nex3 merged commit 470447f into feature.color-4 Apr 12, 2024
29 checks passed
@nex3 nex3 deleted the merge-main branch April 12, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants